[PATCH] serial: samsung: fix device name

Joonyoung Shim jy0922.shim at samsung.com
Fri Aug 6 03:06:10 EDT 2010


On 8/6/2010 3:47 PM, Paulius Zaleckas wrote:
> On 08/06/2010 03:04 AM, Kyungmin Park wrote:
>> Hi,
>>
>> It's already posted by Mr. Shim
>> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2
> 
> Darius patch is a little bit cleaner.
> 

OK, it's better.

Acked-by: Joonyoung Shim <jy0922.shim at samsung.com>

>> As discussed with Ben. even though it's right patch, there's some
>> users to use previous interface.
>> I also think it will be fixed. but need to coordinate with existing
>> users.
> 
> IMO this is obvious bug fix.
> 
> Acked-by: Paulius Zaleckas <paulius.zaleckas at gmail.com>
> 
>> Ben, how to you think?
>>
>> On Fri, Aug 6, 2010 at 5:10 AM, Darius
>> Augulis<augulis.darius at gmail.com>  wrote:
>>> Swap device and driver names in serial/samsung.c
>>>
>>> Signed-off-by: Darius Augulis<augulis.darius at gmail.com>
>>> ---
>>>   drivers/serial/samsung.c |    4 ++--
>>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
>>> index a9d6c56..9d63f24 100644
>>> --- a/drivers/serial/samsung.c
>>> +++ b/drivers/serial/samsung.c
>>> @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
>>>
>>>   static struct uart_driver s3c24xx_uart_drv = {
>>>         .owner          = THIS_MODULE,
>>> -       .dev_name       = "s3c2410_serial",
>>> +       .driver_name    = "s3c2410_serial",
>>>         .nr             = CONFIG_SERIAL_SAMSUNG_UARTS,
>>>         .cons           = S3C24XX_SERIAL_CONSOLE,
>>> -       .driver_name    = S3C24XX_SERIAL_NAME,
>>> +       .dev_name       = S3C24XX_SERIAL_NAME,
>>>         .major          = S3C24XX_SERIAL_MAJOR,
>>>         .minor          = S3C24XX_SERIAL_MINOR,
>>>   };
>>>
>>>
>>> _______________________________________________
>>> linux-arm-kernel mailing list
>>> linux-arm-kernel at lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>>
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-serial" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> 




More information about the linux-arm-kernel mailing list