[alsa-devel] [PATCH 1/2] ARM: S5PV210: Add audio support to Aquila

[Mark Brown]

On Wed, Aug 04, 2010 at 03:16:51PM +0900, Chanwoo Choi wrote:
> Mark Brown wrote:

> > OK, good - the fact that the connection wasn't being made with the PMIC
> > was my main point here.

> Did you read writed mail about consumer supply of WM8994 by MyungJoo Ham?

I saw it, yes.

> He is in charge of PMIC and Power Management on Aquila board.

> MyungJoo Ham is wrote : 
> This aquila_buck3_data.constraints would be better have ".always_on =
> 1" entry as this buck3 is required to be turned on at all times in
> Aquila boards (even when the system is in suspend-to-mem state). This
> is required especially when there are many devices physically attached
> to Buck3 and some of they did not "register" as consumers to Buck3.
> Buck3 might be turned off by those who are registered while
> "unregistered" are still active.

> Can you tell me your opinion about the review by MyungJoo Ham?
> I will respect your response.

I think his comments are sensible.  The constraints should always try to
reflect the actual constraints of the system as closely as possible.