Please remind 'WARNING: about Samsung merge window over'

[Kukjin Kim]

Russell King wrote:
> 
> On Mon, Aug 02, 2010 at 05:35:37PM +0900, Kyungmin Park wrote:
> > As the maintainer, he merged his features freely but others can't get
> > the chance if the implementation is not fit his taste or company
> > policy.
> >
> > Look at the example.
> > [PATCH v2 0/4] ARM: S5P: Support gpio interrupts
> > http://marc.info/?l=linux-arm-kernel&m=127840208508625&w=2
> >
> > We need the gpio interrupt support but he refused it since it used too
> > many irq. Actually his board don't use this features.
> > "It is because there are too many gpio interrupts and having support
> > of all of them is unnecessary as realistically only few of them maybe
> > used."
> 
> From my count, there's already 144 IRQs, and you'll be adding 27*8 = 216
> additional IRQs to that.  That's quite small compared to some platforms
> which have in the order of 512 or even 1024 IRQs.
> 
> > And current kernel don't support the sparse irq feature. then it's
> > reasonable to merge it first and revise it later.
> 
> sparse irq support has been queued for almost a month for the merge
> window which has just this morning opened.  This doesn't help you if
> you instantiate all your 360 interrupts though - just because you
> don't _use_ an interrupt which has been declared as existing doesn't
> reduce the size of the arrays.
> 
> > Another why FIMC support is missing? we modified it as his requested
> > and send it properly.
> > [PATCH v3 3/8] ARM: Samsung: Add platform definitions and helpers for
> > http://marc.info/?l=linux-arm-kernel&m=127990218813931&w=2
> 
> This looks like it's been missed.  People get busy and miss things on
> the mailing list, there's nothing special about that.
> 
Yeah...actually I missed reply for it...so I requested re-submit v4 patch to
Marek with some modifying and finished review it just now.

> > [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P
> > http://marc.info/?l=linux-arm-kernel&m=127990218613922&w=2
> 
> Kukjin Kim replied to this one with a point requiring an answer, but
> nothing came back.
> 
>    "Looks ok...however, I'm still thinking whether really need all these
>     definitions."
> 
> Seems to be a perfectly reasonable point to raise, and if there's no
> reply to justify them...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.