[2.6.34-rc6] ARM: build breaks with KPROBES

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Apr 30 03:47:45 EDT 2010

On Fri, Apr 30, 2010 at 12:51:49PM +0530, Shilimkar, Santosh wrote:
> Russell,
> The latest mainline ARM build breaks with KPROBES enabled. Anand
> Gadiyar did git bisect and figured out that below commit breaks the build.
> 	commit :4260415f6a3b92c5c986398d96c314df37a4ccbf

Did you read the comments in the commit message to understand why
.previous is dangerous?

> I tried matching the sections but failed to fix the build error. Below
> is the hack patch to keep build working.

The previous section is not .text, but:

        .section        .kprobes.text,"ax",%progbits

Either change the preceding .data to .pushsection .data, and the following
.text to .popsection, or duplicate the above ifdef; .pushsection/.popsection
is _far_ safer than using .previous.

More information about the linux-arm-kernel mailing list