Potential namespace problem for 'struct flash_platfrom_data'
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Apr 29 16:19:44 EDT 2010
On Thu, Apr 29, 2010 at 03:06:37PM -0500, H Hartley Sweeten wrote:
> Hello all,
>
> I was looking at an issue with a spi flash device and noticed a
> potential namespace problem.
>
> arch/arm/include/asm/mach/flash.h has this:
>
> struct flash_platform_data {
> const char *map_name;
> const char *name;
> unsigned int width;
> int (*init)(void);
> void (*exit)(void);
> void (*set_vpp)(int on);
> void (*mmcontrol)(struct mtd_info *mtd, int sync_read);
> struct mtd_partition *parts;
> unsigned int nr_parts;
> };
>
> and include/linux/spi/flash.h has this:
>
> struct flash_platform_data {
> char *name;
> struct mtd_partition *parts;
> unsigned int nr_parts;
>
> char *type;
>
> /* we'll likely add more ... use JEDEC IDs, etc */
> };
>
> Should anything be done?
How about unifying them both?
More information about the linux-arm-kernel
mailing list