[PATCH 1/7] PL330: Add common core driver

[jassi brar]

On Mon, Apr 26, 2010 at 1:56 PM, Ben Dooks <ben-linux at fluff.org> wrote:
> On Sun, Apr 25, 2010 at 03:59:26AM +0200, Linus Walleij wrote:
>> 2010/4/24 jassi brar <jassisinghbrar at gmail.com>:
>> > Btw, I think that driver should be divided in two files
>> > drivers/dma/api-pl330.c with common code and
>> > drivers/dma/<soc>-pl330.c for platform specific stuff like IRQ,
>> > registers base mapping and other quirks(if any). Any opinions?
>
> Possibly, but I think it may be better to pass these things via platform
> device for registers and irqs, and platform data for the quirks.
Some platforms implement just one i/f either secure or non-secure, others
might implement both. Having a separate file for platforms would make
it possible to switch between secure and non-secure i/fs acc to the needs
of the platform. Similarly for the DMAC reset mechanism.
Also, I am afraid, managing quirks in common code might get trickier over time.