[PATCH 1/7] PL330: Add common core driver

jassi brar jassisinghbrar at gmail.com
Fri Apr 23 19:20:48 EDT 2010


On Sat, Apr 24, 2010 at 6:49 AM, Linus Walleij
<linus.ml.walleij at gmail.com> wrote:
> 2010/4/21  <jassisinghbrar at gmail.com>:
>
>> PL330 is a configurable DMA controller PrimeCell device.
>> The register map of the device is well defined.
>> The configuration of a particular implementation can be
>> read from the six configuration registers CR0-4,Dn.
>
> I think this looks better for every iteration and is definately ripe
> for merge, so FWIW:
> Acked-by: Linus Walleij <linus.walleij at stericsson.com>
Thanks.

>> The exported interface should be sufficient to implement
>> a driver for any DMA API.
>
> Will you make an attempt at doing this in time for the next
> merge window as well? That would be perfect.
Actually I said "any DMA API" i.e, some platform, like S3C,
may choose to implement their own API.

You mean the DMA engine driver for PL330, right?
Since Joonyoung's driver was pre-empted by these patches,
he might want to re-write parts of his driver for this backend.
If he doesn't show any interest in a few days, I'll do it.

Btw, I think that driver should be divided in two files
drivers/dma/api-pl330.c with common code and
drivers/dma/<soc>-pl330.c for platform specific stuff like IRQ,
registers base mapping and other quirks(if any). Any opinions?



More information about the linux-arm-kernel mailing list