[PATCH V2] mach-pxa/viper: Fix timeout usage for I2C
w.sang at pengutronix.de
Mon Apr 19 21:03:52 EDT 2010
On Tue, Apr 20, 2010 at 08:20:46AM +0800, Eric Miao wrote:
> On Sun, Apr 18, 2010 at 7:48 PM, Wolfram Sang <w.sang at pengutronix.de> wrote:
> > The timeout value is in jiffies, so it should be using HZ, not a plain
> > number. Assume with HZ=100 '100' means 1s here and adapt accordingly.
> > Signed-off-by: Wolfram Sang <w.sang at pengutronix.de>
> > Cc: Eric Miao <eric.y.miao at gmail.com>
> > Cc: Russell King <linux at arm.linux.org.uk>
> > Cc: Marc Zyngier <maz at misterjones.org>
> > Cc: Paul Shen <paul.shen at marvell.com>
> > Cc: Mike Rapoport <mike at compulab.co.il>
> > Cc: Jean Delvare <khali at linux-fr.org>
> > ---
> > Changes since V1:
> > * Don't assume 100 means 100ms
> > Thanks for the comments!
> > Admitted, the first try was a really bad guess. Maybe I got distracted from the
> > previous patch for another arch where the value was 10000.
> > While this may still not be the favoured solution for Eric, I think it is at
> > least better than before, so it might be worth applying after all?
> Ack. The clearest fix would involve more code to be updated, which
> can be postponed. This fix, at least, makes the time quantity clearer.
Thanks. Can you pick it up? Because it is a change to a board-file.
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: Digital signature
More information about the linux-arm-kernel