[RFC PATCH 10/10] mx5: Add MX53 EVK board support

Timur Tabi timur.tabi at gmail.com
Mon Apr 19 16:53:01 EDT 2010


On Mon, Apr 19, 2010 at 3:47 PM, Herring Robert-RA7055
<ra7055 at freescale.com> wrote:

>> You forgot to run checkpatch.pl.  C++ comments are not allowed.
>
> Yes I know. I'm only soliciting comments on the way I have structured adding MX53 to MX51 codebase.

Ok.

>> How about:
>>
>> #define mxc_init_imx_uart() do { } while (0)
>
> Just following existing code style in board-mx51_babbage.c.

I understand, but I believe the consensus for general kernel
development is to use "#define .. do while(0)" to represent a no-op
function.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the linux-arm-kernel mailing list