[RFC PATCH 10/10] mx5: Add MX53 EVK board support

Timur Tabi timur.tabi at gmail.com
Mon Apr 19 16:40:26 EDT 2010


On Fri, Apr 16, 2010 at 2:35 PM, Rob Herring <r.herring at freescale.com> wrote:

> +/* Serial ports */
> +#if defined(CONFIG_SERIAL_IMX) || defined(CONFIG_SERIAL_IMX_MODULE)
> +static struct imxuart_platform_data uart_pdata = {
> +//     .flags = IMXUART_HAVE_RTSCTS,

You forgot to run checkpatch.pl.  C++ comments are not allowed.

> +#else /* !SERIAL_IMX */
> +static inline void mxc_init_imx_uart(void)
> +{
> +}
> +#endif /* SERIAL_IMX */

How about:

#define mxc_init_imx_uart() do { } while (0)

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the linux-arm-kernel mailing list