[PATCH 2/2] n2100: reduce power button timer to 1 Hz

Aaro Koskinen aaro.koskinen at nokia.com
Mon Sep 28 04:06:36 EDT 2009


Hello,

Mikael Pettersson wrote:
> 10 Hz seems excessive, so this patch adds a compile-time option
> to reduce the polling frequency to 1 Hz.
> 
> (This change could possibly be handled via a kernel boot option,
> or even be made unconditional, but I opted for a compile-time
> option for now.)

I don't think there is need to have an option for this. With HZ also
round_jiffies() could be used, it doesn't need to be exact.

(I also think the code should check that the button is held down for
a while before doing the shutdown, but that's a different issue.)

A.



More information about the linux-arm-kernel mailing list