[PATCH 1/3] [ARM]: U8500 core machine support

[Surinder P Singh]

On Thu, Sep 24, 2009 at 8:13 PM, Surinder P Singh <srplsnh at gmail.com> wrote:
> Some review comments:
>
>> diff --git a/arch/arm/mach-ux500/include/mach/debug-macro.S b/arch/arm/mach-ux500/include/mach/debug-macro.S
>> +
>> +#include <linux/amba/serial.h>
>> +               .macro  addruart,rx
>> +               mrc     p15, 0, \rx, c1, c0
>> +               tst     \rx, #1                 @MMU enabled?
>> +               moveq   \rx, #0x80007000        @MMU off, Physical address
>> +               movne   \rx, #0xF0007000        @MMU on, Virtual address
>> +               .endm
>> +
>
> It looks like the constants used here will break compilation. You
> could instead use 0x80000000 and 0xf0000000 and add an 'orr \rx, \rx,
> #0x7000' after the 'movne' to fix this.
>

You can also remove serial.h from here since this is now included in
debug-pl01x.S