platform data for the s3c-adc or hardcoded delay?

Arnaud Patard (Rtp) arnaud.patard at rtp-net.org
Thu Sep 24 09:37:32 EDT 2009


Nelson Castillo <arhuaco at freaks-unidos.net> writes:

Hi,

> (Ben, sorry for sending 2 copies. I used the old list address... I'd
> better go to sleep now.).
>
>
> We had this for the touchscreen but it doesn't make sense now that the
> driver has been converted to use the s3c-adc API.
>
> const static struct s3c_ts_platdata gta02_ts_cfg = {
>       .delay = 10000,
>       .presc = 0xff, /* Slow as we can go. */
> };
>
> Without this delay the TS doesn't work for us:
>
> Now I see two options:
>
> 1) Hardcode the delay in plat-s3c24xx/adc.c (As it's done in [1]).
> 2) Submit patches adding s3c_adc_platdata.

I would rather go for a platdata. I do believe that prescaler and delay
are machine specifics.

Arnaud



More information about the linux-arm-kernel mailing list