[PATCH 2/3] regulator: add 88PM8607 PMIC driver

Mark Brown broonie at sirena.org.uk
Tue Sep 22 17:56:00 EDT 2009

On Wed, Sep 23, 2009 at 02:13:05AM +0800, Eric Miao wrote:
> Forwarded to correct mailing list manually, pity.

> >> Yes, MFD core driver can take this job also. But it addes more
> >> initialization code in custom MFD driver.

> > I'd agree with this.

> > I don't see any point that the use of the MFD API is mandatory here. This
> > is really a simple and straightforward task to add all the sub-devices
> > (as platform_device - though I don't like this platform_device at all), and
> > maybe in a specific manner the composite device needs, we don't really
> > need to involve all those mfd_cell, and resource copying stuffs.

The point I was making wasn't so much about using the MFD API itself as
about the fact that I'd expect the bit of the device driver that sits
under drivers/mfd to know about all the subdevices that needed
registering, especially for things which don't usually need any system
specific configuration.  I'd probably not have said anything if the
original code hadn't taken the entire list of subdevices in as platform

More information about the linux-arm-kernel mailing list