[PATCH v4] arm: remove unused code in delay.S

Felipe Contreras felipe.contreras at gmail.com
Sat Sep 19 20:16:14 EDT 2009

2009/9/19 Steve Chen <schen at mvista.com>:
> On Sat, 2009-09-19 at 15:47 +0200, Uwe Kleine-König wrote:
>> Hello Steve,
>> On Sat, Sep 19, 2009 at 07:55:29AM -0500, Steve Chen wrote:
>> > Document #if 0 code block in delay.S and make it selectable for compile.
>> >
>> > Signed-off-by: Steve Chen <schen at mvista.com>
>> > Reviewed-by: Felipe Contreras <felipe.contreras at gmail.com>
>> > Reviewed-by: Jamie Lokier <jamie at shareable.org>
>> > Reviewed-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
>> > Reviewed-by: Krzysztof Halasa <khc at pm.waw.pl>
>> > Reviewed-by: Marek Vasut <marek.vasut at gmail.com>
>> > Reviewed-by: Pavel Machek <pavel at ucw.cz>
>> > Reviewed-by: Sergei Shtylyov <sshtylyov at ru.mvista.com>
>> > Reviewed-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>> I'm very surprised you added these Reviewed-by: tags.
>> IMO you should not add them without the explicit permission and request
>> of the corresponding person.  (That means that at least mine should not
>> be there.)
>> Moreover Reviewed-by: has a meaning (described in
>> Documentation/SubmittingPatches).
> My only intention was to give credit to all who contributed (at least try).  I already
> sent out a patch with all Reviewed-by tags removed.  I can add back in anyone who wish
> to be added.

It's better to say:
Comments by Felipe Contreras, Jamie Lokier, Jean-Christophe, etc.

I did not review your patch, I merely provided the original one, and
made some comments.


Felipe Contreras

More information about the linux-arm-kernel mailing list