[PATCH 02/10] S3C64XX I2S: declared i2s_v4

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Sep 16 06:22:10 EDT 2009

On Wed, Sep 16, 2009 at 01:12:20AM +0100, Ben Dooks wrote:
> On Tue, Sep 15, 2009 at 07:02:34PM +0900, Jassi wrote:

> > -	.id		  = -1,
> > +	.name		  = "s3c64xx-iis",
> > +	.id		  = 2,

> I'd like to see how much different the two drivers are, and whether they
> need to be seperated into their own modules.

There's substantial overlap (mostly IISv4 just adds new register bits to
control the additional channels), but the trick would be how the driver
is supposed to work out that it's handling an IISv4 device and enable
the additional functionality.

> Changing the name to s3c64xx-iis means that the module auto-load may end
> up loading the wrong module. Holding off on this change until we se what
> needs to be done for this block.

It's certainly not a long-term solution as-is.

More information about the linux-arm-kernel mailing list