[PATCH 01/10] S3C64XX I2S: S3C64XX_PA_IISV4 defined
Ben Dooks
ben-linux at fluff.org
Tue Sep 15 20:09:25 EDT 2009
On Tue, Sep 15, 2009 at 07:02:33PM +0900, Jassi wrote:
> Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as
> it's not avaialble for 6400
>
> Signed-Off-by: Jassi <jassi.brar at samsung.com>
> ---
> arch/arm/mach-s3c6400/include/mach/map.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-s3c6400/include/mach/map.h
> index 5057d99..775577a 100644
> --- a/arch/arm/mach-s3c6400/include/mach/map.h
> +++ b/arch/arm/mach-s3c6400/include/mach/map.h
> @@ -44,6 +44,9 @@
> #define S3C64XX_PA_SYSCON (0x7E00F000)
> #define S3C64XX_PA_IIS0 (0x7F002000)
> #define S3C64XX_PA_IIS1 (0x7F003000)
> +#ifdef CONFIG_CPU_S3C6410
> +#define S3C64XX_PA_IISV4 (0x7F00D000)
> +#endif
Does this really need to be #ifdef'd out? You might want to avoid
building the device setup code, or similar if it is only for a s3c6400
but this should be done by the machine Kconfig chosing to build the
support in for the machines that do need it.
I see no good reason for this to be applied.
> #define S3C64XX_PA_TIMER (0x7F006000)
> #define S3C64XX_PA_IIC0 (0x7F004000)
> #define S3C64XX_PA_IIC1 (0x7F00F000)
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
More information about the linux-arm-kernel
mailing list