[PATCH 09/10] S3C64XX I2S: Set parent links for clock audio-bus.
Mark Brown
broonie at opensource.wolfsonmicro.com
Tue Sep 15 07:12:04 EDT 2009
On Tue, Sep 15, 2009 at 07:02:41PM +0900, Jassi wrote:
> Explicitly route audio-bus from FOUTepll via MOUTepll.
> Signed-Off-by: Jassi <jassi.brar at samsung.com>
Why do this in the audio driver rather than doing it in the arch/arm
code? It seems bad form for the audio driver to be looking at clock
configuration outside its domain.
> + cm = clk_get(NULL, "mout_epll");
> + if (IS_ERR(cm)) {
> + dev_err(&pdev->dev, "failed to get mout_epll\n");
> + ret = PTR_ERR(cm);
> + goto mout_err;
> + }
> + clk_set_parent(i2s->iis_cclk, cm);
> + cf = clk_get(NULL, "fout_epll");
> + if (IS_ERR(cf)) {
> + dev_err(&pdev->dev, "failed to get fout_epll\n");
> + ret = PTR_ERR(cf);
> + goto fout_err;
> + }
> + clk_set_parent(cm, cf);
The mout/fout connection in particular isn't audio local, there's way
more EPLL users than just the audio.
More information about the linux-arm-kernel
mailing list