[PATCH 5/7] S3C64XX DMA: TC-IRQ implemented.
jassisinghbrar at gmail.com
Tue Sep 15 07:04:05 EDT 2009
On Tue, Sep 15, 2009 at 7:13 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Tue, Sep 15, 2009 at 07:01:23PM +0900, Jassi wrote:
>> + if (errstat & bit)
>> + writel(bit, dmac->regs + PL080_ERR_CLEAR);
> The old code would complain in the logs on error, which seems like a
> reasonable approach if we've no better idea what to do - it at least
> tells people something about what might be going on if things break.
Yes, some debug mssg wud be better.
>> + chan = dmac->channels + offs;
>> + if(chan->curr == NULL)
>> + continue;
> It's probably a good idea to run your patches through
> scripts/checkpatch.pl before submitting them.
ahhhh.... my me!!
More information about the linux-arm-kernel