[PATCH 09/12] [ARM][S3C6410] Add definitions of keypad register

[Kyungmin Park]

On Mon, Sep 7, 2009 at 7:07 PM, Jinsung Yang<jsgood.yang at samsung.com> wrote:
> Hi,
>
>> Can you re-organize it as each register. I mean KEYIFCON fileds first,
>> KEYIFSTRCLR files second and so on.
>>
>> Can't figure out well
>>
>
> I'm not sure what you tell me about..
> Do you mean something like that?
>
> #define REG1
> #define REG1_FIELD1
> #define REG1_FIELD2
>
> #define REG2
> #define REG2_FIELD1
> #define REG2_FIELD2
>
> #define REG3
> #define REG3_FIELD1
> #define REG3_FIELD2
>
> Or like this?
> #define REG1
> #define REG2
> #define REG3
>
> #define REG1_FIELD1
> #define REG1_FIELD2
> #define REG2_FIELD1
> #define REG2_FIELD2
> #define REG3_FIELD1
> #define REG3_FIELD2
>

latter

 #define REG1_OFFSET
 #define REG2_OFFSET
 #define REG3_OFFSET

/* REG1 field */
#define REG1_FIELD1
#define REG1_FIELD2

/* REG2 field */
#define REG2_FIELD1
#define REG2_FIELD2

/* REG3 field */
#define REG3_FIELD1
#define REG3_FIELD2

How about to review the another keypad drivers?

Thank you,
Kyungmin Park