[PATCH 08/12] [ARM][S3C6410] Add platform device support for keypad driver

Jinsung Yang jsgood.yang at samsung.com
Mon Sep 7 06:10:29 EDT 2009


Hi

> Where's the copyright? Don't forget to add copyright

Sorry, I'll add it.
> > +void __init s3c_keypad_set_platdata(struct s3c_platform_keypad *pd)
> > +{
> > +       struct s3c_platform_keypad *npd;
> > +
> > +       if (!pd)
> > +               pd = &default_keypad_data;
> 
> If you want to set the default it. just assign it at platform_device
> directly. No need to check pd at here.
> 
Ok, got it. I will modify with following your comments.

Best Regards
--
Jinsung, Yang <jsgood.yang at samsung.com>
AP Development Team
System LSI, Semiconductor Business
SAMSUNG Electronics Co., LTD




More information about the linux-arm-kernel mailing list