[PATCH 01/12] [ARM][S3C6410] keypad memory map support

[Kyungmin Park]

On Mon, Sep 7, 2009 at 10:49 AM, Jinsung Yang<jsgood.yang at samsung.com> wrote:
>> -----Original Message-----
>> From: kyungmin78 at gmail.com [mailto:kyungmin78 at gmail.com] On Behalf Of
>> Kyungmin Park
>> Sent: Monday, September 07, 2009 9:09 AM
>> To: 양진성
>> Cc: ben-linux at fluff.org; 김경일/AP개발팀/E3/삼성전자; linux-arm-
>> kernel at lists.infradead.org
>> Subject: Re: [PATCH 01/12] [ARM][S3C6410] keypad memory map support
>>
>> Hi,
>>
>> First, where's keypad driver source codes?
>> Second, why how many patches are needed? I think only two patch, one
>> for keypad related, another is smdkc100 board specific.
>
> I sent keypad source code to the linux-input mailing lists and Ben Dooks as cc.

I see.

> I have to send keypad driver also to arm-linux as public? I'm not sure..

For who only subscribe the arm list. It's not problem to post two
mailing list with same topic.
If only input patches are merged and arm doesn't, then what happens?

> And, the reason why I sent many patches is that we should split all changes as change-set based.
> Even though these changes are related just with single topic (keypad), the details should be published as individual change-set.

I agree Mark Brown's opinion from input mailing list. Please consider
what's the concept of change-set vs change one.

Thank you,
Kyungmin Park

> Harald who is supporting our team's mainline work has recommended that.
>
>>
>> Thank you,
>> Kyungmin Park
>>
>>
>> 2009/9/5 양진성 <jsgood.yang at samsung.com>:
>> > This patch introduces keypad memory map for new keypad driver.
>> > Also the new keypad driver will be provided to the mainline soon.
>> >
>> > Signed-off-by: Jinsung Yang <jsgood.yang at samsung.com>
>> > Signed-off-by: Kyeongil Kim <ki0351.kim at samsung.com>
>> > ---
>> >  arch/arm/mach-s3c6400/include/mach/map.h |    6 ++++++
>> >  1 files changed, 6 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-
>> s3c6400/include/mach/map.h
>> > index 5057d99..d935570 100644
>> > --- a/arch/arm/mach-s3c6400/include/mach/map.h
>> > +++ b/arch/arm/mach-s3c6400/include/mach/map.h
>> > @@ -65,6 +65,10 @@
>> >  #define S3C_VA_VIC0            (S3C_VA_IRQ + 0x00)
>> >  #define S3C_VA_VIC1            (S3C_VA_IRQ + 0x10000)
>> >
>> > +/* keypad */
>> > +#define S3C64XX_PA_KEYPAD      (0x7E00A000)
>> > +#define S3C64XX_SZ_KEYPAD      SZ_4K
>> > +
>> >  /* compatibiltiy defines. */
>> >  #define S3C_PA_TIMER           S3C64XX_PA_TIMER
>> >  #define S3C_PA_HSMMC0          S3C64XX_PA_HSMMC0
>> > @@ -75,5 +79,7 @@
>> >  #define S3C_PA_FB              S3C64XX_PA_FB
>> >  #define S3C_PA_USBHOST         S3C64XX_PA_USBHOST
>> >  #define S3C_PA_USB_HSOTG       S3C64XX_PA_USB_HSOTG
>> > +#define S3C_PA_KEYPAD          S3C64XX_PA_KEYPAD
>> > +#define S3C_SZ_KEYPAD          S3C64XX_SZ_KEYPAD
>> >
>> >  #endif /* __ASM_ARCH_6400_MAP_H */
>> > --
>> > 1.6.2.5
>> >
>> >
>> > _______________________________________________
>> > linux-arm-kernel mailing list
>> > linux-arm-kernel at lists.infradead.org
>> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>> >
>
>