Samsung S3C6410 mainline merge coordination
broonie at sirena.org.uk
Fri Sep 4 09:41:21 EDT 2009
On Fri, Sep 04, 2009 at 10:08:43AM +0900, jassi brar wrote:
> Brown<broonie at sirena.org.uk> wrote:
> > The machine driver should just pick a suitable configuration and go with
> > it. ?This isn't something which users should need to be concerned about
> I think the 'suitable' configuration is the one that the user(device
> maker) wants.
> Because i think platform designers already are pretty sure of what
> mode they wanna run the SoC-I2S in - they won't run SoC in MASTER mode
> if they have attached a good OSC to the CODEC.
Quite, this is one of the reasons why this shouldn't be exposed in
Kconfig - the choice of clock master will either not matter or will have
been fixed at hardware design time.
> Btw, what cud be the criteria of switch from SoC Master to SoC Slave
> during runtime?
Some systems with more complex audio will need to reclock the system at
runtime when moving between different use cases, often due to things
like making tradeoffs between power and quality. This will almost
always be managed by the machine driver and certainly isn't going to be
an issue for any of the SMDKs that I've seen.
> Machine driver should runtime configure Cpu_Dai and Codec_Dai as per
> the Master/Slave and Clock sourcing options it "got from make
No, this is not something that should be offered as a configuration
option. As I've said the machine driver should just pick a
configuration that works well on the hardware and go with that.
Presenting the configuration means that users need to understand the
various options that are being offered and come to a decision. Since
the end result will be that either one of the options is clearly better
(in which case there is no reason to choose the other option) or there's
no difference (in which case why bother the user with the decision in
the first place) this at best achieves nothing but wasting a bit of
their time and at worst will confuse them.
If someone has modified the hardware then they will most likely want to
produce a new machine driver anyway. If someone is interested in
evaluating the various configurations (probably with the view to
producing their own board) they can easily modify the source code.
With a Kconfig choice they're going to have to rebuild the kernel to
change configurations anyway.
More information about the linux-arm-kernel