Samsung S3C6410 mainline merge coordination

jassi brar jassisinghbrar at
Wed Sep 2 09:44:35 EDT 2009

On Wed, Sep 2, 2009 at 9:11 PM, Harald Welte<laforge at> wrote:
> On Wed, Sep 02, 2009 at 11:05:01AM +0100, Mark Brown wrote:
>> > === Sound ===
>> > * needs further investigation, there are many different drivers/versions/options
>> Merge any changes in with the mainline drivers - there's relatively
>> little difference from the s3c24xx IPs.  There's a reasonable chance
>> I'll get round to this myself for the 64xx series since I have one which
>> I'm using for some of my development.
> Apparently there are also features like operating the SoC codec in slave mode
> as well as different clock configurations wich mainline is missing.

Yes, none of mainline SMDK supports SoC-Slave mode or sourcing I2S IP with
various possible clocks(PCLK, EPLL, CDCLK) etc yet. Samsung tree has
and fully tested these features for 6410, 6440 and C100.

My idea is to submit only "better enabled" I2S driver with Slave support.
Clock sourcing related patch maybe later added when the EPLL etc clock
support has been submitted.

An issue though.
In the long run, I see I2S drivers segregated by the I2S spec version
they implement....
S3C2410 has I2S-2.0, S3C6410 has I2S-3.2 and I2S-4.0, S5P6440 has
I2S-4.0, S5PC100 has
I2S-3.2 and I2S-5.1 and so on. That is, we have something like
samsung-i2s_v20.c, samsung-i2s_v32.c,
samsung-i2s_v40.c, samsung-i2s_v51.c.
SoC specific register addresses and other peculiarities maybe
differentiated by defines in coresp. header files.
Let Samsung come with as many SoCs as it wishes, I2S support will
simply end up in header files. Also, that we
can do away with using s3c24xx stuff in 64xx and S5Pxxxx code.
For now, I haven't implemented h/w mixing and 5.1 channel support so
v32 and v40 are just the same.
Whereas, mainline s3c-i2s approach currently concentrates on
extracting common code in one file(s3c-i2s-v2.c) or so do i think.

I sincerely seek to discuss this issue.

More information about the linux-arm-kernel mailing list