[RFC 09/11] ARM: Add I-cache invalidation for VIVT ASID tagged caches

[Catalin Marinas]

On Sun, 2009-10-25 at 13:35 +0000, Russell King wrote:
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> ---
>  arch/arm/mm/flush.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c
> index dc66f86..9770e27 100644
> --- a/arch/arm/mm/flush.c
> +++ b/arch/arm/mm/flush.c
> @@ -69,6 +69,9 @@ void flush_cache_range(struct vm_area_struct *vma, unsigned long start, unsigned
>  		    : "cc");
>  		__flush_icache_all();
>  	}
> +
> +	if (vma->vm_flags & VM_EXEC && icache_is_vivt_asid_tagged())
> +		__flush_icache_all();
>  }
>  
>  void flush_cache_page(struct vm_area_struct *vma, unsigned long user_addr, unsigned long pfn)
> @@ -82,6 +85,9 @@ void flush_cache_page(struct vm_area_struct *vma, unsigned long user_addr, unsig
>  		flush_pfn_alias(pfn, user_addr);
>  		__flush_icache_all();
>  	}
> +
> +	if (vma->vm_flags & VM_EXEC && icache_is_vivt_asid_tagged())
> +		__flush_icache_all();
>  }
>  
>  void flush_ptrace_access(struct vm_area_struct *vma, struct page *page,

You may be right but why is this needed? Between mm's, we have the ASID.
Within the same mm, do we expect to change the corresponding physical
address of a virtual address without calling update_mmu_cache?

-- 
Catalin