Kernel related (?) user space crash at ARM11 MPCore

[Russell King - ARM Linux]

On Tue, Oct 20, 2009 at 12:39:08PM +0100, Catalin Marinas wrote:
> diff --git a/arch/arm/mm/fault-armv.c b/arch/arm/mm/fault-armv.c
> index d0d17b6..4e37ab6 100644
> --- a/arch/arm/mm/fault-armv.c
> +++ b/arch/arm/mm/fault-armv.c
> @@ -160,8 +160,7 @@ void update_mmu_cache(struct vm_area_struct *vma, unsigned long addr, pte_t pte)
>  	if (mapping) {
>  		if (cache_is_vivt())
>  			make_coherent(mapping, vma, addr, pfn);
> -		else if (vma->vm_flags & VM_EXEC)
> -			__flush_icache_all();
> +		__flush_icache_all();

BTW, why are you penalising VIVT cached systems as well with this
change?  Surely you meant to leave the 'else' still there.