[PATCH 43/46] DaVinci: remove unneeded #include's

Kevin Hilman khilman at deeprootsystems.com
Fri Oct 23 16:49:02 EDT 2009


Sergei Shtylyov <sshtylyov at ru.mvista.com> writes:

> Hello.
>
> Kevin Hilman wrote:
>
>> From: Sergei Shtylyov <sshtylyov at ru.mvista.com>
>
>> There have accumulated quite a lot of them after the code reorganizations...
>
>> In several cases I had to replace #include <linux/dma-mapping.h> which wasn't
>> needed directly but happened to #include <linux/err.h> which was needed.
>
>> Signed-off-by: Sergei Shtylyov <sshtylyov at ru.mvista.com>
>> Signed-off-by: Kevin Hilman <khilman at deeprootsystems.com>
>
> [...]
>
>> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
>> index b804d57..120ede0 100644
>> --- a/arch/arm/mach-davinci/da850.c
>> +++ b/arch/arm/mach-davinci/da850.c
>> @@ -11,24 +11,21 @@
>>   * is licensed "as is" without any warranty of any kind, whether express
>>   * or implied.
>>   */
>> -#include <linux/kernel.h>
>>  #include <linux/init.h>
>>  #include <linux/clk.h>
>> -#include <linux/platform_device.h>
>>  #include <linux/cpufreq.h>
>>  #include <linux/regulator/consumer.h>
>>   #include <asm/mach/map.h>
>>  -#include <mach/clock.h>
>>  #include <mach/psc.h>
>> -#include <mach/mux.h>
>>  #include <mach/irqs.h>
>>  #include <mach/cputype.h>
>>  #include <mach/common.h>
>>  #include <mach/time.h>
>>  #include <mach/da8xx.h>
>>  #include <mach/cpufreq.h>
>> +#include <linux/platform_device.h>
>
>    As has been pointed out, this is not in its proper group. Perhaps
> the patch can be changed before pushing upstream, and removal and
> addition of this line just nullified?

Indeed, I'll clean this up in the davinci-next branch.

Thanks,

Kevin



More information about the linux-arm-kernel mailing list