[PATCH v3 4/4] iop: implement sched_clock()

Mikael Pettersson mikpe at it.uu.se
Thu Oct 22 18:17:29 EDT 2009


Dan Williams writes:
 > Hi Mikael,
 > 
 > On Fri, Oct 16, 2009 at 3:00 PM, Mikael Pettersson <mikpe at it.uu.se> wrote:
 > > This adds a better sched_clock() to the IOP platform,
 > > implemented using its new clocksource support.
 > >
 > > Tested on n2100, compile-tested for all plat-iop machines.
 > >
 > > Signed-off-by: Mikael Pettersson <mikpe at it.uu.se>
 > > ---
 > 
 > I applied this series and my iop13xx does not get past "Uncompressing
 > Linux".  Bisecting points to this patch i.e. the other three are ok
 > (at least for booting).  Any ideas?  I won't have time to debug this
 > for a while.

Thanks for testing and for doing the bisection.

Actually I do have an idea what it might be. sched_clock() is
"registered" (if you can call it that) at link-time simply by
virtue of being defined, while the other machinery it needs
(clocksource) is enabled at boot-time at some semi-unknown point.
So there's an early boot-time window where calls to sched_clock()
may occur but won't work.

I've seen vague references to this issue in other platforms'
code, but nothing really concrete. Obviously I never saw that
issue on my n2100 and frankly forgot about it until now.

I'll have to grep around for the appropriate fix; in the mean
time, just dropping this one patch is the right solution, as
nothing else in this series depends on it.

/Mikael



More information about the linux-arm-kernel mailing list