[PATCH] Zaurus: Fix PROM partition table for spitz

Pavel Machek pavel at ucw.cz
Thu Oct 22 17:45:11 EDT 2009


On Fri 2009-10-23 05:33:27, Eric Miao wrote:
> On Fri, Oct 23, 2009 at 5:13 AM, Stanislav Brabec <utx at penguin.cz> wrote:
> > Eric Miao wrote:
> >> I'm a bit upset that some things else may depend on the original
> >> layout (though that's incorrect), and this possibly breaks the
> >> sequence numbering of /dev/mtd?.
> >
> > It can break in many ways, e. g. by compiling one as module and another
> > into kernel, and depends on order of modules load.
> >
> > That is why software should search partitions by name.
> >
> 
> But there might be software that doesn't. I'd be a little bit
> conservative about this.
> 
> > AFAIK, nothing uses the EN-JP or initial bootloader data in the 2.6.x
> > distros, so it should be just safe housekeeping.
> >
> 
> This, on the other hand, says it's also safe not to inserting
> some additional partition in between :-)
> 
> (I won't refuse some comments to make this more clear in the code
> though).

I don't know. If the table is wrong, we should fix it. Yes, it may
break someone, but it probably will not.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



More information about the linux-arm-kernel mailing list