[PATCH 38/46] davinci: fix compilation error when using mach/system.h

Kevin Hilman khilman at deeprootsystems.com
Mon Oct 19 14:33:11 EDT 2009


Russell King - ARM Linux <linux at arm.linux.org.uk> writes:

> On Fri, Oct 16, 2009 at 12:09:42PM -0700, Kevin Hilman wrote:
>> From: Sekhar Nori <nsekhar at ti.com>
>> 
>> include/mach/system.h uses the cpu_do_idle() function which is
>> defined in asm/proc-fns.h. Without this patch including system.h
>> leads to error of the sort:
>> 
>> error: implicit declaration of function 'cpu_do_idle'
>
> The right answer might actually be to ensure that arch/arm/kernel/process.c
> includes this file, so that all mach/system.h files don't have to.

Maybe it should be more explicit, but at least on 2.6.32, process.c
already triggers an include of <asm/proc-fns.h> (linux/mm.h ->
asm/pgtable.h -> asm/proc-fns.h.

IIRC, the problem was not with arch/arm/kernel/process.c other
mach-davinci files using <mach/system.h> for some reason.

After Sergei's major #include cleanup for mach-davinci/*, I don't
think this is actually necessary anymore.

Sekhar, I'll drop this patch from davinci-next unless you think this
is still necessary for some reason.

Kevin



More information about the linux-arm-kernel mailing list