[PATCH] SA1100: fix building of h3100

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Oct 6 07:28:31 EDT 2009


On Tue, Oct 06, 2009 at 12:53:18PM +0200, Kristoffer Ericson wrote:
> On Mon,  5 Oct 2009 21:50:34 +0400
> Dmitry Artamonow <mad_soft at inbox.ru> wrote:
> 
> > Both iPaqs h3100 and h3600 currently share the same source
> > file - h3600.c  But Makefile builds it only if CONFIG_SA1100_H3600
> > selected, so selecting just CONFIG_SA1100_H3100 results in
> > "no machine record defined" message and aborted compilation.
> > 
> > Fix it.
> 
> Acked

If there are people seriously looking at H3[16]00 stuff, it would be
a good idea to move it over to use the proper GPIO support rather
than continue to rely upon its own version.

Also maybe splitting it into h3100.c and h3600.c, with (if any) common
bits in h3xxx.c might be an idea?



More information about the linux-arm-kernel mailing list