[PATCH 1/4] Made VMALLOC_END of type unsigned long.

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Oct 1 09:05:22 EDT 2009


On Thu, Oct 01, 2009 at 12:48:55PM +0200, Andreas Fenkart wrote:
> Here it is, rebased against commit
> 7fa07729e439a6184bd824746d06a49cca553f15.
> 
> I added macros simplifying the printout message, as your suggested.
> Patches are now split/merged differently so they describe one logical
> step.
> 
> Unfortunately the macros you suggested trigger a checkpatch.pl
> warning:
> 
> ERROR: Macros with complex values should be enclosed in parenthesis
> #628: FILE: arm/mm/init.c:628:
> +#define MLM(b, t) b, t, ((t) - (b)) >> 20

This is a case where ignoring checkpatch.pl is the right thing to do.
It doesn't know what is trying to be achieved, and is trying to apply
an inappropriate rule.

I'd ignore this warning.



More information about the linux-arm-kernel mailing list