[PATCH 1/3] AT91: update at91_eth_data for ETX2-3 on PA10-11

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Nov 30 23:54:59 EST 2009


On 22:36 Mon 30 Nov     , Andrew Victor wrote:
> hi Patrick,
> 
> > This patch update the at91_eth_data to handle the usage of PA10 and PA11
> > for EMAC's EXT2 and EXT3 signals.
> 
> > @@ -83,6 +83,7 @@ struct at91_eth_data {
> >        u32             phy_mask;
> >        u8              phy_irq_pin;    /* PHY IRQ */
> >        u8              is_rmii;        /* using RMII interface? */
> > +       u8              use_twi_pins;   /* ETX2-ETX3 on PA23-PA24 */
> >  };
> 
> The "at91_eth_data" structure is used on all AT91 processors with a
> MACB peripheral (AT572D940HF, CAP9, 9620, 9263).
> So this isn't really a nice cross-platform change.
I agree 'use_twi_pins' is not the best name maybe alternate_pins or routing
will be better to describe it and will be generic enouch to match all soc

Best Regards,
J.



More information about the linux-arm-kernel mailing list