[PATCH] genirq: warn about IRQF_SHARED|IRQF_DISABLED at the right place

David Brownell david-b at pacbell.net
Mon Nov 30 15:21:30 EST 2009


On Monday 30 November 2009, Uwe Kleine-König wrote:
> +               if (new->flags & IRQF_DISABLED)
> +                       pr_warning("IRQ %d/%s: IRQF_DISABLED is not guaranteed "
> +                                       "on shared IRQs\n", irq, new->name);

This should have copied the original test ... this way,
it's dropping the SHARED constraint, and trying to morph
into a generic "IRQF_DISABLED is eeebil!" test.

If it just moved the original test, I'd have no problem
with the patch.


... although it'd still not address the general mess in
this area, it'd at least not introduce false warnings.



More information about the linux-arm-kernel mailing list