[RESENT PATCH] Don't disable irqs in set_next_event and set_mode callbacks

Thomas Gleixner tglx at linutronix.de
Fri Nov 27 14:08:55 EST 2009


On Fri, 27 Nov 2009, Uwe Kleine-König wrote:
> > which basically leaves us with the implementations interrupt handling
> > function.  If that always calls the event handler with IRQs disabled,
> > then set_next_event will also be called with IRQs disabled.
> Thomas, do you care to shed light on this?

I answered this before and still all CE functions are called with irqs
disabled. The timer interrupt is required to run with irqs disabled
and it was so before we switched to CE and the generic implementation.

> If you don't care I suggest to add the same check as for at91rm2000 for
> the other platforms and see what happens.

And as last time I suggest to add a comment to the ce struct
documentation, only this time I'll do it myself.

Thanks,

	tglx


More information about the linux-arm-kernel mailing list