[PATCH 16/17] ALSA: ARM: add Raumfeld audio support

Daniel Mack daniel at caiaq.de
Thu Nov 26 12:51:50 EST 2009


On Wed, Nov 25, 2009 at 01:29:13PM +0000, Mark Brown wrote:
> On Wed, Nov 25, 2009 at 01:24:36PM +0100, Daniel Mack wrote:

> > No, it wasn't.
> 
> There was at least one unrelated driver for a different part - I
> remember the discussion since someone needed to explain to people (Alan
> Cox, I think) that this wasn't an RTC but rather a TDM clock generator.
> 
> >   http://marc.info/?l=linux-i2c&m=122457836326525&w=2
> 
> > Jean Delvare's last comment on this was:
> 
> > > Honestly I don't see any value in this driver. There's nothing you can
> > > do with it that you couldn't already do without it.
> 
> > The driver itself would do the right thing, but I doubt that
> > resubmitting will help much.
> 
> Looking at the thread in the archive I don't see any effort to answer
> Jean's question there - the reply from Jon talks about device tree
> binding which is, as Jean says, pretty much irrelevant to the question:
> 
>    http://marc.info/?l=linux-i2c&m=122465761327694&w=2
> 
> The question seemed to be more about what the driver was supposed to
> accomplish - talking about the functionality is provided by the driver
> once it's bound to the device should address that.

Ok, will probably get back to this later. For now, I left the code where
it was but changed the API to make it clearer. The actual implementation
is in one line only, so I see no urgent need to move it to an own driver
immediately. Let me know if you're fine with the new version I'll post
soon.

Thanks,
Daniel




More information about the linux-arm-kernel mailing list