[PATCH 05/17] ARM: pxa/raumfeld: add rotary encoder support

Daniel Mack daniel at caiaq.de
Wed Nov 25 10:50:31 EST 2009


On Wed, Nov 25, 2009 at 05:26:38PM +0200, Mike Rapoport wrote:
> Daniel Mack wrote:
> >  static void __init raumfeld_common_init(void)
> >  {
> >  	enable_irq_wake(IRQ_WAKEUP0);
> > @@ -174,6 +197,12 @@ static void __init raumfeld_common_init(void)
> >  
> >  static void __init raumfeld_controller_init(void)
> >  {
> > +	struct platform_device *raumfeld_controller_devices[] = {
> > +		&rotary_encoder_device,
> > +	};
> 
> Any reason to keep the devices array inside the function? I think it makes the
> code less readable.

Ok - changed for the next round.

Thanks,
Daniel



More information about the linux-arm-kernel mailing list