[PATCH] ep93xx: add missing parentheses in IOMEM macro

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Nov 19 17:38:38 EST 2009


On Tue, Nov 17, 2009 at 11:36:36AM -0500, H Hartley Sweeten wrote:
> On Tuesday, November 17, 2009 4:49 AM, Hubert Feurstein wrote:
> >
> > Signed-off-by: Hubert Feurstein <h.feurstein at gmail.com>
> > ---
> >  arch/arm/mach-ep93xx/include/mach/io.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-ep93xx/include/mach/io.h b/arch/arm/mach-ep93xx/include/mach/io.h
> > index 594b77f..ddb6e32 100644
> > --- a/arch/arm/mach-ep93xx/include/mach/io.h
> > +++ b/arch/arm/mach-ep93xx/include/mach/io.h
> > @@ -14,7 +14,7 @@
> >   * A typesafe __io() variation for variable initialisers
> >   */
> >  #ifdef __ASSEMBLER__
> > -#define IOMEM(p)		p
> > +#define IOMEM(p)		(p)
> >  #else
> >  #define IOMEM(p)		((void __iomem __force *)(p))
> >  #endif
> 
> I think the __ASSEMBLER__ version of the IOMEM macro is missing the
> parentheses on purpose.
> 
> Maybe Russell can shed some light on this.

Well, parens shouldn't hurt assembly, so it should be safe to add them.



More information about the linux-arm-kernel mailing list