[PATCH 09/19] drivers: serial: add support for Samsung S5PC110 SoC uart
jassisinghbrar at gmail.com
Thu Nov 19 06:26:34 EST 2009
On Thu, Nov 19, 2009 at 8:08 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Thu, Nov 19, 2009 at 08:05:29PM +0900, jassi brar wrote:
>> On Thu, Nov 19, 2009 at 7:33 PM, Mark Brown
>> > This is going to set off warnings from a clock API point of view -
>> > passing clock names around in platform data is usually a sign that
>> > something is very wrong. Keeping the mapping inside the clock API
>> > (still controlled by the board driver but by telling the clock API that
>> > device X should use clock Y).
>> no clock pointer needs to be passed, just a pointer to an array of _strings_
>> There is no need to even include any clock header in platform code
>> for the purpose.
> Yes, that's what I was commenting on - like I say, passing clock names
> tends to set off the same alarm bells as passing a struct clk. Like I
> say, the general model for this has been that the fixups will be done by
> having the machine code talk to the clock API ratehr than bouncing the
> data about the clock to use through the driver.
The case here is that UART controller can source from various platform clocks
to generate the UART clocks. The drivers/serial/samsung.c chooses a source
clock that can result in closest match to the requested rate.
How could we do that from machine code(except for writing callbacks for each
machine using the SoC)?
Or maybe i cud understand better looking at some example.
Cud u suggest some please?
More information about the linux-arm-kernel