[PATCH 09/19] drivers: serial: add support for Samsung S5PC110 SoC uart

jassi brar jassisinghbrar at gmail.com
Thu Nov 19 06:05:29 EST 2009


On Thu, Nov 19, 2009 at 7:33 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Thu, Nov 19, 2009 at 11:44:14AM +0900, jassi brar wrote:
>
>> Let each platform code(SoC specific) define names of all possible
>> source clocks and let the board init code pass on the potential source
>> clocks by some bit-mask(or some other mechanism) while setting the
>> platform data.
>
> This is going to set off warnings from a clock API point of view -
> passing clock names around in platform data is usually a sign that
> something is very wrong.  Keeping the mapping inside the clock API
> (still controlled by the board driver but by telling the clock API that
> device X should use clock Y).
no clock pointer needs to be passed, just a pointer to an array of _strings_
There is no need to even include any clock header in platform code
for the purpose.



More information about the linux-arm-kernel mailing list