drivers/rtc/rtc-pl031.c uses __raw_readl()?

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Nov 19 05:49:12 EST 2009


On Thu, Nov 19, 2009 at 09:43:59AM +0000, Russell King - ARM Linux wrote:
> So where do we stand on this?  Are Primecell registers always LE?  Or
> can they be BE if running in one of the BE modes?
> 
> I'm not merging the patch until we have a definitive answer on this.

Linus, you just said in the patch system that this is in akpm's tree.

Since we don't know whether this patch is even right or not, it's not
something which should be there.  It's not a bug fix nor is it a known
improvement.  It's just a hunch.

It may be that the existing code is correct and the other primecell
drivers that are using readb() rather than __raw_readb() need fixing.
We just don't know at present.



More information about the linux-arm-kernel mailing list