IXP4xx: unneeded #include platform-specific include files?
kaloz at openwrt.org
Tue Nov 17 17:34:35 EST 2009
On 2009.11.17. 23:22:21 Krzysztof Halasa <khc at pm.waw.pl> wrote:
> "Imre Kaloz" <kaloz at openwrt.org> writes:
>> Why wouldn't you want to remember that "INTA" was "GPIO8"? When you want to
>> touch those lines you do have to remember or look up what GPIO was that one.
>> So this hardly makes it easier to work with or to remember to -- it certainly
>> duplicates the assignments, as you've also noted.
> Actually I'm not sure if I understand you correctly.
> If I use GPIO8 (presumably in different places) I have to remember what
> it is. This may be use with a couple of IRQ lines but gets harder and
> harder with a more complicated machine. Macros like SLOT0_INTA etc.
> don't have this problem. That's BTW why macros and symbolic names were
I doubt they were invented for "#define a b" "#define b c" "#define c d" games.
>> The INTx naming convention is also stupid, as in most cases these are
>> not different
>> INT lines of the PCI slot but either separate slots or subdevices -- and note,
>> most of the boards only have INTa connected mechanically.
>> And I didn't even get to the topic of *_PCI_MAX_DEV, *_PCI_IRQ_LINES
>> and the mania
>> of pci_irq_table usage..
> But you've seen the patches I just posted, haven't you?
Yeah, you get rid of the external .h files for dropping all that bloat into the setup
files. Honestly, do however you please, but this hardly makes sense IMHO when you have
the chance to get rid of all this mess.
More information about the linux-arm-kernel