[PATCH] arm pxa: remove "direction input" forcing for IRQ GPIOs

Eric Miao eric.y.miao at gmail.com
Tue Nov 17 07:12:52 EST 2009


On Tue, Nov 17, 2009 at 6:05 AM, Rodolfo Giometti <giometti at enneenne.com> wrote:
> On Tue, Nov 17, 2009 at 12:44:29PM +0100, Daniel Mack wrote:
>> On Tue, Nov 17, 2009 at 12:21:46PM +0100, Rodolfo Giometti wrote:
>> > PXA CPUs may use their GPIOs as IRQ lines even if they are selected as
>> > outputs (see for example figure 24-1 into PXA27x Processor Family
>> > Developer's Manual). So forcing GPIOs IRQ lines as inputs is not
>> > correct.
>> >
>> > Programmers should set up GPIOs direction according to their usage and
>> > the function pxa_gpio_irq_type() should simply enable the IRQ
>> > detection.
>>
>> Interesting. Is this an academic issue or do you actually use that?
>> That would mean you externally drive the IO pin level to something else
>> than the output driver provides, which isn't healthy at all.
>
> It's a real configuration with no electrical drawbacks at all! Of
> course the driver's output must be passive (I use it to detect a CARD
> insert) but it's functional.

Well, that might be possible configuration but as long as there is no
real issue with this, I'd prefer the safe guard here remain intact atm.



More information about the linux-arm-kernel mailing list