[PATCH] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform

[Marc Zyngier]

On Tue, 17 Nov 2009 08:52:54 +0100
Marek Szyprowski <m.szyprowski at samsung.com> wrote:

> From: Kyungmin Park <kyungmin.park at samsung.com>
> 
> Samsung S5PC100 SoC has SDHCI controller compatible to the one known
> from S3C64xx SoCs. Enable support for sdhci-s3c driver also on
> S5PC1xx platform.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> Acked-by: Ben Dooks <ben-linux at fluff.org>
> ---
>  drivers/mmc/host/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 432ae83..faddf82 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -96,7 +96,7 @@ config MMC_SDHCI_PLTFM
>  
>  config MMC_SDHCI_S3C
>  	tristate "SDHCI support on Samsung S3C SoC"
> -	depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX)
> +	depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX ||
> PLAT_S5PC1XX) help
>  	  This selects the Secure Digital Host Controller Interface
> (SDHCI) often referrered to as the HSMMC block in some of the Samsung
> S3C

I think it was Ben that suggested once to introduce a HAVE_SDHCI_S3C
symbol, selected by interested parties (S3C, S5P, S5PC...).

Given the way Samsung SoCs are assembled (from an IP point of view), it
would make sense for one SoC to describe its features in
"HAVE_FEATURE_FOO" terms rather than each subsystem depending an ever
growing list of SoC.

	M.
-- 
Fast. Cheap. Reliable. Pick two.