[PATCH 06/10] mfd add subdevs in 88pm860x

Haojian Zhuang haojian.zhuang at gmail.com
Tue Nov 17 01:31:34 EST 2009


On Fri, Nov 13, 2009 at 11:50 PM, Dmitry Torokhov
<dmitry.torokhov at gmail.com> wrote:
> On Fri, Nov 13, 2009 at 04:00:44AM -0500, Haojian Zhuang wrote:
>>
>> -             count = ARRAY_SIZE(pm8607_devs);
>> -             for (i = 0; i < count; i++) {
>> -                     ret = mfd_add_devices(chip->dev, i, &pm8607_devs[i],
>> -                                           1, NULL, 0);
>> -                     if (ret != 0) {
>> -                             dev_err(chip->dev, "Failed to add subdevs\n");
>> -                             goto out;
>> -                     }
>> +             mfd_add_devices(chip->dev, 0, &regulator_devs[0],
>> +                                   ARRAY_SIZE(regulator_devs),
>> +                                   &regulator_resources[0], 0);
>> +
>> +             if (pdata && pdata->touch) {
>> +                     mfd_add_devices(chip->dev, 0, &touch_devs[0],
>> +                                     ARRAY_SIZE(touch_devs),
>> +                                     &touch_resources[0], 0);
>
> Where did error handling go?
>
> --
> Dmitry
>

Updated.

Thanks
Haojian


More information about the linux-arm-kernel mailing list