[PATCH 07/10] backlight: enable backlight in 88pm860x
Haojian Zhuang
haojian.zhuang at gmail.com
Tue Nov 17 01:30:20 EST 2009
On Sat, Nov 14, 2009 at 12:02 AM, Dmitry Torokhov
<dmitry.torokhov at gmail.com> wrote:
> On Fri, Nov 13, 2009 at 04:02:24AM -0500, Haojian Zhuang wrote:
>> +
>> +static int pm860x_backlight_set(struct backlight_device *bl, int brightness)
>> +{
>> + struct pm860x_backlight_data *data = bl_get_data(bl);
>> + struct pm860x_chip *chip = data->chip;
>> + unsigned char value;
>> + int ret;
>> +
>> + if ((wled_a(data->port) < 0) || (wled_b(data->port) < 0)
>> + || (wled_idc(data->port) < 0))
>> + return -EINVAL;
>> +
>
> Do you even need to register blacklight device if data->port is negative?
>
> --
> Dmitry
>
Right. Code is updated.
Haojian
More information about the linux-arm-kernel
mailing list