IXP4xx: unneeded #include platform-specific include files?

Mike Westerhof mike at mwester.net
Sun Nov 15 13:41:32 EST 2009


Krzysztof Halasa wrote:
> I wonder about one more thing: why are the platform-specific include
> files included by the non-platform code?
> 
> mach-ixp4xx/include/mach/hardware.h:
> 
> /* Platform specific details */
> #include "ixdp425.h"
> #include "avila.h"
> #include "coyote.h"
> #include "prpmc1100.h"
> #include "nslu2.h"
> #include "nas100d.h"
> #include "dsmg600.h"
> #include "fsg.h"
> 
> I'm going to move them to the platform code, either incorporate them
> into platform .c files or #include "specific-platform.h" from there.
> 
> Objections?

None at all (for nslu2 and dsmg600 platforms).
-Mike (mwester)




More information about the linux-arm-kernel mailing list