[PATCH 8/8] pxa: add frame buffer on pxa910 ttc_dkb platform

[Russell King - ARM Linux]

On Thu, Nov 12, 2009 at 10:20:20AM +0800, Jun Nie wrote:
> +static int tpo_lcd_power(struct pxa168fb_info *fbi, unsigned int spi_gpio_cs, unsigned int spi_gpio_reset, int on)
> +{
> +	int err = 0;
> +
> +	if (on) {
> +		if (spi_gpio_reset != -1) {
> +			err = gpio_request(spi_gpio_reset, "TPO_LCD_SPI_RESET");
> +			if (err) {
> +				printk("failed to request GPIO for TPO LCD RESET\n");
> +				return -1;

Do you really mean -EPERM here?  If not, use a proper error code such as
the one you got from gpio_request().  (Never, ever, use a literal "-1" as
an error indicator in the kernel.)