[PATCH] ARM: Prefix revision number in /proc/cpuinfo

Daniel Mack daniel at caiaq.de
Thu Nov 12 09:37:07 EST 2009


On Thu, Nov 12, 2009 at 03:30:20PM +0100, Alessandro Rubini wrote:
> > The revision field in /proc/cpuinfo is reported as hex number, so it
> > should have a '0x' prefix to make that clear. Otherwise, parsers
> > will take it as decimal number unless it contains a letter.
> 
> If the problem is real (I assume it is), why don't you fix all
> fields?
> 
> > -	seq_printf(m, "Revision\t: %04x\n", system_rev);
> > +	seq_printf(m, "Revision\t: 0x%04x\n", system_rev);
> >  	seq_printf(m, "Serial\t\t: %08x%08x\n",
> >  		   system_serial_high, system_serial_low);
> 
> "Serial", above, is hex as well.

Yes, but the serial number is more likely to be taken as string, I
thought. Anyway, below is a new patch.

Daniel




More information about the linux-arm-kernel mailing list