[REGRESSION] 2eca40a8 breaks StrongARM compilation
Russell King - ARM Linux
linux at arm.linux.org.uk
Wed Nov 11 14:32:57 EST 2009
On Wed, Nov 11, 2009 at 10:23:15PM +0300, Dmitry Artamonow wrote:
> Commit 2eca40a8 which went into 2.6.32-rc6 breaks compilation
> for ipaq h3600 and probably other SA1100 machines when CONFIG_CPU_FREQ
> is unset:
I'm aware, I have a very large patch which fixes SA1100, but there's
other ARM machine classes which are similarly broken.
We've been around this loop before, where a change like this was
introduced and reverted. The kernel community seems set to constantly
repeat the same old mistakes time and time again.
> +#ifdef CONFIG_CPU_FREQ
> pcd = get_pcd(var->pixclock, cpufreq_get(0));
> + pcd = get_pcd(var->pixclock, 206400);
This is just not acceptable, and could lead to LCD panel damage due
to wrong timings - not all platforms boot at 206.4MHz. Given that
it's far better that the kernel be obviously broken than silently
wrong while causing hardware damage.
More information about the linux-arm-kernel